Fix clippy errors in sample code #77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code masks flags with O_RDONLY, which is 0: > .read((flags & O_RDONLY != 0) | (flags & O_RDWR != 0)) This generates Clippy errors because it's equivalent to 0 & 0 != 0. The correct code uses O_ACCMODE to mask off the lower bits: > .read((flags & O_ACCMODE == O_RDONLY) | (flags & O_ACCMODE == O_RDWR)) The code could be further simplified with `let access_flags = flags & O_ACCMODE` at the top, but this version maintains the original intent and consistency with similar libinput examples across the internet. This commit updates all 3 occurrences of the code fragment. Fixes Smithay#66 Signed-off-by: Tom Stokes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code masks flags with O_RDONLY, which is 0:
This generates Clippy errors because it's equivalent to 0 & 0 != 0.
The correct code uses O_ACCMODE to mask off the lower bits:
The code could be further simplified with
let access_flags = flags & O_ACCMODEat the top, but this version maintains the original intent and consistency with similar libinput examples across the internet.This commit updates all 3 occurrences of the code fragment.
Fixes #66